Re: [Monotone-devel] internalize_rsa_keypair_id()

[Timothy Brownawell]

On Fri, 2009-08-14 at 04:24 +0000, Timothy Brownawell wrote:
> On Sun, 2009-07-26 at 21:10 -0700, Zack Weinberg wrote:
> > On Sun, Jul 26, 2009 at 4:36 PM, Timothy Brownawell<address@hidden> wrote:
> > > Is there any particular reason that we ACE-encode[1] the domain part
> > > (after the '@') of key names on input, and then never decode them (the
> > > only place that externalize_rsa_keypair_id() is ever called is when
> > > writing _MTN/options)? I'm working on making certs link to keys by hash
> > > instead of name, which seems like a perfect opportunity to also get rid
> > > of this since the schema is changing anyway.
> 
> On further thought I'm not sure this would even need to be a schema
> change, because the values are never ever decoded. Just drop the
> encoding and note in NEWS that non-ascii names will actually work now.
> 
> It's not dropping the coding would turn my chineese cert names into
> punycoded cert names and break my scripts that use them, because they
> already show as punycoded cert names. The only effect would be on the
> scripts generating the certs, which would get to actually match the
> scripts using them.
> 
> So, now I'm proposing to drop the encoding and not try to migrate
> anything. Because migrating would break as much stuff as not migrating.

This is done now, 88490b82b12035397273da2d882fb2f428ffc57f.

It's a single commit, so should be easy to revert if we decide it was
actually a horrible idea.

-- 
Timothy

Free public monotone hosting: http://mtn-host.prjek.net