Re: [Monotone-devel] nvm.experiment.database-management

[Thomas Keller]

Am 18.05.2010 14:41, schrieb Thomas Keller:
> Am 18.05.2010 14:07, schrieb Thomas Keller:
>> Am 18.05.2010 13:46, schrieb Stephen Leake:
>>> Perhaps this is one reason the dbcache was a member of the application
>>> class?
>>
>> Well, it should not - unless its considered bad practise to store
>> shared_ptr's in a static map - I found a couple of references with
>> similar problems, but no quick explanation or solution. I need to
>> investigate this further.
> 
> This is the problem when I just copy over the existing code and don't
> think for myself - the issue was the reference to the shared_ptr in the
> database constructor which rendered the reference counting of shared_ptr
> useless. I changed that in 35cfbc0b277b7c0a5e3a401688078cee11dc20ad and
> mtn no longer crashes for me. Can you confirm that?

Forget this "fix" - it won't cache database_impl instances at all. I'll
look further into the issue tonight.

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature