Re: [Monotone-devel] Lua issue in devel/monotone

[Markus Wanner]

Olaf,

On 10/14/2013 06:02 PM, Rhialto wrote:
> On Mon 14 Oct 2013 at 10:05:41 +0200, address@hidden wrote:
>> Hm.. you're right, that change was misguided. I changed it to
>> pclose() because it's pipes to and from a process. But you are right
>> in that it's not opened with popen().
> 
> I looked at the source of popen() and pclose() on NetBSD. popen()
> creates some data, including the process ID of the process it creates.
> pclose() looks that up, so that it can wait() for that process. If it
> doesn't recognize the FILE pointer, it simply does nothing and fails.
> ( 
> http://cvsweb.NetBSD.org/bsdweb.cgi/src/lib/libc/gen/popen.c?rev=1.32&content-type=text/x-cvsweb-markup&only_with_tag=MAIN
>  )
> On linux the checks are probably different.
> 
>> Uh.. what did gcc complain about? I'll have to diff that against the
>> source to figure what you changed.
> 
> The error message was (from memory) "ok may be used before
> initialization" or "used before initialized" something along those
> lines.
> 
> Btw, in the patch I initialized it to 0 but thinking about it, it should
> probably be 1 (assuming that means "ok").

Thanks for clarification. I committed a patch in
3c0f6bb751ccd497e2b0028bbde55af91126ec4e.

Regards

Markus