Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt

[Benno Schulenberg]

Hello Rishabh,

On Tue, Jun 21, 2016, at 15:47, Rishabh Dave wrote:
> Patch for the bug - https://savannah.gnu.org/bugs/?48286 - is attached.
> 
> It basically snips code that opens directory under the body of
> statement "else if (func == goto_dir_void)" in do_browser() in
> browser.c and replaces new_path by newpath

Yes.  I was waiting for you to submit a patch doing that.  :)

Patch looks good.  At first I thought it would be nice to "select"
(to highlight) the inaccessible directory, but that is difficult,
and is not generally possible because it might be outside of the
current dir.  So, let it be as it is -- these are highly unlikely 
cases after all.

> I have added a comment and tryed to keep it short but it, to me, looks
> imprecise; doesn't capture the fact that newpath could be null.

Could it be NULL?  How?  Because if so, that would be bad: it would
crash on doing "if (newpath[0] != '/')".

> [I purposefully first submitted a report and then the patch over the
> mail, hoping that that helps record-keeping.]

Yes, very good.  Bugs are easier to reference than threads on
a mailing list.

Benno

-- 
http://www.fastmail.com - mmm... Fastmail...