Re: [Nano-devel] Softwrap navigation overhaul

[Benno Schulenberg]

> On Fri, Feb 3, 2017, at 16:24, David Ramsey wrote:
> > Version 2b is attached.  It's now 34 patches on the softwrap side [...]

Oh, 0001:

+int go_back_chunks(size_t *leftedge, filestruct **line, int nrows);
+int go_forward_chunks(size_t *leftedge, filestruct **line, int nrows);

You swapped the line and leftedge parameters?  Why?  What I wished
to see was nrows as first parameter, as that is what "chunks" is
synonymous with.

0005:

-    if (column == 0 || column < editwincols - 1)
+    if (ISSET(SOFTWRAP) || column == 0 || column < editwincols - 1)

Optimize for the most common case: non-softwrap, not column zero:

+    if (column < editwincols - 1 || ISSET(SOFTWRAP) || column == 0)

0007, 0008:

Applied and pushed.  They are independent from the overhaul.

Benno

-- 
http://www.fastmail.com - Email service worth paying for. Try it for free