[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] New Feature: completion from external dictionary
From: |
Marco Diego Aurélio Mesquita |
Subject: |
Re: [Nano-devel] New Feature: completion from external dictionary |
Date: |
Mon, 9 Jul 2018 14:55:28 -0300 |
On Sat, Jul 7, 2018 at 2:24 PM, Benno Schulenberg <address@hidden> wrote:
>
> Hi Marco,
>
> Thanks for the patch. I will look at it next week. First I have
> some catching up to do -- I have been on vacation.
>
>> It is still missing the ability to reload the dictionary only if its> date
>> has been changed, but that will be my next change.
> This doesn't sound like a necessary feature. So make sure to make
> it a separate patch. In general: when applicable, cut up any new
> feature into the smallest patches that make sense by themselves.
>
Ok. Attached is the patch with minimal features implemented. I also
cleaned it up so that it now deserves a review.
Please review it.
completer.patch
Description: Text Data