Re: [PATCH] fixed: calculation of mouse click position in get_mouseinput()

[Benno Schulenberg]

Op 22-12-2020 om 17:19 schreef ObeliX:
>>> version B patch is my (if-style correct) original patch
>>
>> Ehm... the other way around: the B patch is the same as your earlier one,
>> just with whitespace corrections.
> 
> ähm, exactly as I wrote it: B is my original patch

But you trimmed what came after it: "that also unifies [...]".  So the
wording seemed to suggest that patch B does something extra over patch A.
Also the naming of the patches suggested this: B comes after A, so it has
evolved, it does extra things...

Never mind.

> I thought you meant, to only fix the margin offset bug, w/o unifying how
> the function reports the position for the prompt bar. the 'extra
> something with the button' in version A patch, is for this
> 'do-as-the-old-code-does'.

But it does it by making a fair lot of changes.  The aim is always
to first fix a bug with as few changes as possible to the code, so
that it is quite easy to verify that the fix is correct.  After
that, follow-up patches can refactor the code to arrange things
more logically.

> the result of your patch and my A-patch is the same.

Good.  I have pushed my patch:

  https://git.savannah.gnu.org/cgit/nano.git/commit/?id=265bdd94

Plus a small follow-up patch to arrange things to my taste.


> (don't no why my answers yesterday, are not linked to your posts in the
> mail archive list. I use the 'reply via email'-button below the
> individual posts,

The button is named wrong: it should be simply called "Send email to".
It just fills in the address of the sender, it doesn't copy the
reference headers in the email that the archives and email agents
use to thread the messages.

> but exchange the TO-address, which is populated with
> your private email, with the nano-devel address. is there an other,
> better way to reply to posts ?)

If you don't want to subscribe to the list, then you can download the
relevant mbox (see top of page of relevant month), import it into your
mailer, and then reply to the relevant messages.  But that is far more
work.

Benno

signature.asc
Description: OpenPGP digital signature