Re: [PATCH] display the current path in browser mode when minibar is active

[Benno Schulenberg]

Op 19-01-2021 om 18:26 schreef ObeliX:
> when minibar is active the titlebar is disabled. thus the browser can't
> display anymore to which directory the currently shown file listing belongs.

Yes, that's a pity.  But do you ever use the file browser?

> as no minibar is displayed in browser mode, functionality was added to
> show the path at minibars position instead.

Hmm.  I don't like it when the files are listed at the top and the DIR:
thing is shown at the bottom.  Anything like this will not be accepted.
People who use --minibar will have to "feel" their way about in the
directory tree.

(Also, patch does not work when using --nohelp.)

> patch is against 64bf3b

This commit doesn't exist.  You dropped a 0.

> -                     minibar();
> +                     minibar(NULL);

Why?  Why modify minibar() when all you want to do is write a banner in one
specific situation: in the browser, where the minibar is not used.

> +     if (ISSET(MINIBAR))
> +             return minibar(path);

Ugly: making it seem it returns a value whereas in fact it "returns" void.

> +             statusblank = 0;          // disable pending blanking as 
> statusline gets overwritten now
> +             /* Draw a colored bar over the full width of the screen. */

Ugly: mixing tail comments with full-line comments.  The latter always have
a leading blank line.

(That's just two comments; there are way more things wrong with the code.)

Benno

signature.asc
Description: OpenPGP digital signature