Re: [PATCH] display the current path in browser mode when minibar is active

[Benno Schulenberg]

Op 21-01-2021 om 10:43 schreef ObeliX:
> On 20.01.21 12:45, Benno Schulenberg wrote:
>> Yes, that's a pity.  But do you ever use the file browser?
> 
> I do, obviously. you should already know this, as I also found the bug
> where the state flags were attached to the directory path at the
> titlebar last month. ;)

You think I remember what anyone posted more than a few days ago?
For me it is: apply patch, mark issue as fixed, forget.

>> Why modify minibar() when all you want to do is write a banner in one
>> specific situation: in the browser, where the minibar is not used.
> 
> the minibar practically replaces the titlebar and includes most of its
> information. as the titlebar displayed the directory path for the file
> browser, I thought it makes sense to do the same for the minibar -
> keeping both functions 'alike' from a SW-design point of view

For me the mini bar means: file name, cursor position, character code,
flags, and percentage.  It doesn't have anything to do with browser or
help or anything else.  This also shows from the code you planted into
minibar(): it does not interact with any of the other code there, it is
a completely separate piece with its own return, which just screams:
separate function.  Plus, you planted it /before/ all the declarations
in minibar(), which is horrible.

> (and to be
> prepared for more alike-functionality ie. for the linter or help view if
> desired).

That is another reason why I resist a browser banner at the bottom: if
accepted, you will want the same thing for the help viewer, and I really
don't want that: the title of the page at the bottom.

Benno

signature.asc
Description: OpenPGP digital signature