Re: [PATCH] tweaks: make three conversion specifications more compliant

[Benno Schulenberg]

Op 08-05-2021 om 08:18 schreef Hussam al-Homsi:
> -                             sprintf(info, "%4ju %cB", (intmax_t)result, 
> modifier);
> +                             sprintf(info, "%4jd %cB", (intmax_t)result, 
> modifier);

It should not be possible for a file to have a negative size, so %d should
not be used.  The 'result' is of type off_t, which I expect to be unsigned
(I can't find its definition), so I don't understand why that intmax_t cast
is there.

> -                     sprintf(hexadecimal, "U+%04X", (unsigned 
> char)*this_position);
> +                     sprintf(hexadecimal, "U+%04hhX", (unsigned 
> char)*this_position);

When using "hh", the cast is superfluous.  And the other way around.
I prefer the cast.

Benno

signature.asc
Description: OpenPGP digital signature