Re: [PATCH] tweaks: make three conversion specifications more compliant

[Liu Hao]

在 2021-05-10 12:46, Hussam al-Homsi 写道:
> The actual type of off_t and the conversion specification used to
> print it are unknown.
> The combination could be int and "%d" on some platforms or long and
> "%ld" on others, etc.

This is correct.

> It's about matching not fitting.
> Now it doesn't change anything on my platform, but that doesn't
> conclude that it's standard or portable.
>
> GCC and Clang will silently compile the following original line in the patch:
>
>          sprintf(hexadecimal, "U+%04X", (unsigned char)*this_position);

This needs no change. The `unsigned char` argument corresponds to the ellipse, so it's promoted to 
`int`, and it is valid to use the `X` specifier which matches the unsigned counterpart of it.



--
Best regards,
Liu Hao

OpenPGP_signature
Description: OpenPGP digital signature