[Octave-bug-tracker] [bug #45331] unpack hangs when output file exists

[Philip Nienhuis]

Update of bug #45331 (project octave):

                  Status:             In Progress => Patch Submitted        

    _______________________________________________________

Follow-up Comment #9:

Changeset attached.

@Rik:
Would you please review and if satisfied push to, well, stable?

I'm not extremely proud of it but it works OK now and tests pass:
- unpacked archives are kept (added "-k" flags)
- "movefile" errors are gone
- no more hangs when gunzip'ing existing files (due to added "-f" flag)
==> as far as bunzip2 goes, I do not know if a forced overwrite is the way to
go. Currently bunzip2 complains if it finds an existing file, as it does in a
shell, but it doesn't hang Octave.

I think (and I already thought so 5 months ago when I first patched unpack.m)
that unpack.m is in need of an overhaul but I lack time for that. It could use
more tests as well - AFAICS only gunzip is tested.


(file #34280)
    _______________________________________________________

Additional Item Attachment:

File name: bug45331.cs                    Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45331>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/