[Octave-bug-tracker] [bug #53275] Variable Editor: Undocking variable window causes it to become nearly full screen

[Dan Sebald]

Follow-up Comment #6, bug #53275 (project octave):

I've programmed a fullscreen action/button into the variable editor panels in
a way that I like.  Please test.  How about we implement this and then later
developers can modify to something else if desired.  That way we can close the
bug report.

It should be ready to go, except there may be some adjustment based on the
following set of questions (or these could be left for addressing elsewhere
individually).  Primarily for Torsten:

1) I've implemented the new icon by using the following "quasi-standard"
definitions:


QIcon::fromTheme ("view-fullscreen")
QIcon::fromTheme ("view-restore")


The above route is intended for matching the look-and-feel of the operating
system GUI.  It's advantage is that the icons come from the system so I didn't
have to add any icon in libgui/src/icons such as:

libgui/src/icons/widget-close-light.png
libgui/src/icons/widget-close-light.svg
libgui/src/icons/widget-close.png
libgui/src/icons/widget-close.svg
libgui/src/icons/widget-dock-light.png
libgui/src/icons/widget-dock-light.svg
libgui/src/icons/widget-dock.png
libgui/src/icons/widget-dock.svg
libgui/src/icons/widget-undock-light.png
libgui/src/icons/widget-undock-light.svg
libgui/src/icons/widget-undock.png
libgui/src/icons/widget-undock.svg

In theory, we could get rid of the above icons and use some of the definitions
here:

https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

I tried

QIcon::fromTheme ("window-close")

as a replacement for libgui/src/icons/widget-close.png and it is a thicker X
but it appears to match what one might see in other applications like FireFox
or the system monitor and so on.  Should we look into changing those?  Or just
wait and see if others run into problems with a missing fullscreen/restore
icon?

2) Also notice that for the main window, and generally for windows in the
wider system, that the titlebar icons are usually a light gray and only become
black when the cursor hovers above them.  I see in the icon list in
ligbui/src/icons there is a "light" version so perhaps that's what the other
icon was intended for but never implemented.  However, I suspect that Qt may
have a means of lightening an icon in the general sense.  So should we attempt
to make the icons in the added titlebars behave in a similar way, i.e., light
gray until cursor hovers over them and they become the dark icons as in the
attached patch?

3) With the patch, if one selects the "undock" QToolBar the panel will pretty
much float right where it is.  I personally get confused by that, maybe
because of the lack of a frame on the floated QDockWidget.  Should I see if
there is some type of flag that will put a frame around the floated window?

4) The tooltip for the new fullscreen QToolButton will dynamically change
based upon whether something is docked, e.g., "Fullscreen undock" vs.
"Fullscreen".  Pay attention to those and see if they make sense.  But also,
check out the tooltips for the adjacent QActions.  They have "widget" within
them, e.g., "Dock widget" and "Close widget".  Does the "widget" add anything?
 Should we get rid of that word?  The user doesn't need to know these are
called widgets.

(file #43471)
    _______________________________________________________

Additional Item Attachment:

File name: octave-ve_improved_fullscreen-djs2018mar05.patch Size:8 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53275>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/