[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer
From: |
Rik |
Subject: |
[Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows |
Date: |
Tue, 27 Mar 2018 12:07:18 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 |
Follow-up Comment #15, bug #53369 (project octave):
The changes don't work for me. I get the warning dialog attached. On the
other hand, it was pretty easy to see how to patch things. I'm compiling to
see if this works
# HG changeset patch
# Parent b0cb0218813cc14562200c90daf22420c96bdefd
diff -r b0cb0218813c -r 64b772db5f7b installer-files/octave-firsttime.vbs
--- a/installer-files/octave-firsttime.vbs Mon Mar 26 18:14:40 2018 -0700
+++ b/installer-files/octave-firsttime.vbs Tue Mar 27 09:05:24 2018 -0700
@@ -40,7 +40,8 @@ End If
startpath = wshShell.ExpandEnvironmentStrings("%UserProfile%")
wshShell.CurrentDirectory = startpath
-wshShell.Run chr(34) & OctavePath & "\bin\octave-gui.exe --gui" & Chr(34), 0
+GUIArg = " " & chr(34) & "--gui" & chr(34)
+wshShell.Run chr(34) & OctavePath & "\bin\octave-gui.exe" & Chr(34) & GUIArg,
0
' free our objects
Set fso = Nothing
diff -r b0cb0218813c -r 64b772db5f7b installer-files/octave.vbs
--- a/installer-files/octave.vbs Mon Mar 26 18:14:40 2018 -0700
+++ b/installer-files/octave.vbs Tue Mar 27 09:05:24 2018 -0700
@@ -42,13 +42,14 @@ GUI_MODE=1
AllArgs = ""
Set wshArgs = WScript.Arguments
For I = 0 to wshArgs.Count - 1
- if wshArgs(I) = "--no-gui" then GUI_MODE=0
+ If wshArgs(I) = "--no-gui" Then GUI_MODE=0
AllArgs = AllArgs & " " & chr(34) & wshArgs(I) & chr(34)
Next
' start octave-gui, either with console shown or hidden
If GUI_MODE = 1 then
- wshShell.Run chr(34) & OctavePath & "\bin\octave-gui.exe --gui" & Chr(34) &
AllArgs, 0
+ AllArgs = AllArgs & " " & chr(34) & "--gui" & chr(34)
+ wshShell.Run chr(34) & OctavePath & "\bin\octave-gui.exe" & Chr(34) &
AllArgs, 0
Else
wshShell.Run chr(34) & OctavePath & "\bin\octave-gui.exe" & Chr(34) &
AllArgs, 1
End If
(file #43698)
_______________________________________________________
Additional Item Attachment:
File name: vbs_warning.png Size:15 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?53369>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, (continued)
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Philip Nienhuis, 2018/03/18
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Mike Miller, 2018/03/18
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Philip Nienhuis, 2018/03/19
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Mike Miller, 2018/03/19
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Mike Miller, 2018/03/20
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Philip Nienhuis, 2018/03/20
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Philip Nienhuis, 2018/03/21
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Rik, 2018/03/26
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Mike Miller, 2018/03/26
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, John Donoghue, 2018/03/27
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows,
Rik <=
- [Octave-bug-tracker] [bug #53369] Octave 4.5.0+ launched from installer runs as hidden process on Windows, Rik, 2018/03/27