[Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal

[Mike Miller]

Follow-up Comment #12, bug #48505 (project octave):

I have carefully gone over the diffs, thanks for going in depth to compare the
build log, but I don't see any problems here.

The changes in your diff are the following

* display-available.c and xerbla.c are now being built with the same set of
warnings options as the rest of Octave, they were being built with no warnings
options before. This seems like a good change.

* __fltk_uigetfile__.cc, __init_fltk__.cc, and __init_gnuplot__.cc are now
being compiled with fewer redundant -I options. All of the -I options that
were there before are still there. I think this is also a good change. If it
breaks something for someone we can fix it by cleaning up or reordering the
CPPFLAGS variables.

As an example from your log file, __init_gnuplot__.cc used to be built with
the following -I options, broken out for clarity, and omitting Octave internal
-I options:


...
-I/usr/include/hdf5/serial
-I/usr/include/GraphicsMagick
-I/usr/include/freetype2
-I/usr/include/freetype2
...
-I/usr/include/freetype2
-I/usr/include/freetype2


where the '...' indicates other compiler options. Now it builds with


-I/usr/include/hdf5/serial
-I/usr/include/GraphicsMagick
-I/usr/include/freetype2
-I/usr/include/freetype2


So it has dropped the number of '-I/usr/include/freetype2' options from four
to two. And the reason for still having it twice is because gnuplot includes
'$(FT2_CPPFLAGS) $(FONTCONFIG_CPPFLAGS)' in its options, both of which include
'-I/usr/include/freetype2' (since Fontconfig depends on FreeType).

The same goes for the fltk source files, it has reduced redundant -I options
but nothing has been lost.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48505>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/