[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #48505] build does not use any warning options
From: |
John W. Eaton |
Subject: |
[Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal |
Date: |
Fri, 13 Jul 2018 03:06:08 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 |
Follow-up Comment #14, bug #48505 (project octave):
Rik: Thanks, that patch will work, but I thought we should use the prototype
for xerbla that is in lo-blas-proto.h instead of repeating it in xerbla.c. So
I included lo-blas-proto.h there and immediately found that it will only work
with C++ because of our use of references instead of pointers. I don't want
to give that up, or complicate things by using references for C++ code and
pointers for C code, so I ended up converting xerbla to C++. Then the
prototypes aren't needed. Here's my change (accidentally pushed as two
changesets when I should have merged them before pushing):
http://hg.savannah.gnu.org/hgweb/octave/rev/9ea68b9e277b
http://hg.savannah.gnu.org/hgweb/octave/rev/a8325f2361c7
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?48505>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, (continued)
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Mike Miller, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, John W. Eaton, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, John W. Eaton, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Mike Miller, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Rik, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Mike Miller, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Mike Miller, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Rik, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Mike Miller, 2018/07/12
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Rik, 2018/07/13
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal,
John W. Eaton <=
- [Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal, Rik, 2018/07/13