|
From: | Markus Mützel |
Subject: | [Octave-bug-tracker] [bug #55895] __go_patch__ fails when NaN vertices exist |
Date: | Thu, 21 Mar 2019 11:20:27 -0400 (EDT) |
User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0 |
Follow-up Comment #11, bug #55895 (project octave): If I understood correctly, coplanar_last_idx only ever had less elements than faces in the patch if there were unclosed contours. I'd guess that the default case is that all faces are closed. So I agree with you that coplanar_last_idx should better be dense (and a std::vector). Also looking at [1] makes me believe that std::vector would be the better choice. Using a "dense" vector would also simplify the conditions on when to increment the iterator... [1]: https://baptiste-wicht.com/posts/2012/12/cpp-benchmark-vector-list-deque.html _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?55895> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |