[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #46645] Can't load struct variables that use a
From: |
Rik |
Subject: |
[Octave-bug-tracker] [bug #46645] Can't load struct variables that use arbitrary fieldnames |
Date: |
Sun, 15 Mar 2020 17:05:26 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko |
Update of bug #46645 (project octave):
Status: Confirmed => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #13:
I reviewed, amended, and checked in Olaf's changeset here
https://hg.savannah.gnu.org/hgweb/octave/rev/ef349f5c320b.
The patch was old enough that it it didn't apply cleanly to the current code
base so I fixed that up. I also changed the variable name "string_identifier"
to "do_name_validation" so that the code can read naturally as "if
(do_name_validation && ...)".
The BIST test was ambiguous in that it used whatever save format was set as
the default. I changed the BIST test to always use '-text' format.
@Mike: I applied this to the dev branch because this doesn't seem like a
critical issue, and stable is supposed to be finalizing for a 6.1 release.
But if you feel it is important you can 'hg graft' it over to stable.
Marking bug fixed and closing report.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?46645>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/