[Octave-bug-tracker] [bug #50831] can't load structure with non-matlab field identifiers from 'text' format file

[Rik]

Update of bug #50831 (project octave):

                  Status:         Patch Submitted => Fixed                  
             Open/Closed:                    Open => Closed                 
                 Summary: can't load structure with non-matlab field
identifiers from 'ascii' format file => can't load structure with non-matlab
field identifiers from 'text' format file

    _______________________________________________________

Follow-up Comment #2:

I changed the summary to refer to files in the 'text' format, rather than
'ascii' format.  Octave doesn't support saving struct variables in ascii
format, only matrices.

I also reviewed, amended, and checked in Olaf's changeset here
https://hg.savannah.gnu.org/hgweb/octave/rev/ef349f5c320b.

The patch was old enough that it it didn't apply cleanly to the current code
base so I fixed that up.  I also changed the variable name "string_identifier"
to "do_name_validation" so that the code can read naturally as "if
(do_name_validation && ...)".

The BIST test was ambiguous in that it used whatever save format was set as
the default.  For most users, this would be '-text', so I made that explicit.

Marking bug fixed and closing report.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?50831>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/