[Octave-bug-tracker] [bug #57641] pkg install fails for noexec /tmp

[Mike Miller]

Update of bug #57641 (project octave):

                  Status:               Confirmed => Patch Submitted        

    _______________________________________________________

Follow-up Comment #10:

Thanks for writing the patch. This is not a full review, and I haven't tested,
just a few "at a glance" comments.

There should be a space after the '!' unary operator.

The error message could be a little clearer, probably needs to be a little
more verbose, something like "pkg: unable to execute temporary files in
directory %s, try 'setenv TMPDIR ...' to use a different directory". We
usually break long error messages like this


  error (["pkg: long error message " ...
          "continues here"]);


I think the call to 'chmod' could use 'system' instead of 'shell', it would be
better to use 'system' when possible.

I'm also not sure how this will work on Windows, or whether it's even
necessary, needs someone with Windows to test.

Also our commit messages are short and only describe "what" was changed, not
"why" it was changed. See for example this commit message:
https://hg.savannah.gnu.org/hgweb/octave/rev/3bf19af20af8

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57641>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/