[Octave-bug-tracker] [bug #58057] preface.texi should depend on contributors.texi

[Michael Orlitzky]

URL:
  <https://savannah.gnu.org/bugs/?58057>

                 Summary: preface.texi should depend on contributors.texi
                 Project: GNU Octave
            Submitted by: mjo
            Submitted on: Fri 27 Mar 2020 02:40:07 PM UTC
                Category: Documentation
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 5.2.0
         Discussion Lock: Any
        Operating System: Any

    _______________________________________________________

Details:

We carry a patch in Gentoo to address a build failure related to the
documentation:


--- a/doc/interpreter/module.mk 2018-04-30 19:03:56.000000000 +0200
+++ a/doc/interpreter/module.mk.new     2018-05-22 12:17:03.587175816 +0200
@@ -368,6 +368,8 @@
        $(AWK) -f $(srcdir)/%reldir%/mkcontrib.awk
$(srcdir)/%reldir%/contributors.in > $@-t && \
        mv $@-t $@
 
+%reldir%/preface.texi: %reldir%/contributors.texi
+
 AUTHORS: %reldir%/preface.texi %reldir%/contributors.texi |
%reldir%/$(octave_dirstamp)
        $(AM_V_MAKEINFO)rm -f $@-t $@ && \
        if [ "x$(srcdir)" != "x." ] && [ -f 
$(srcdir)/%reldir%/contributors.texi ]
&& [ ! -f %reldir%/contributors.texi ]; then \


During a parallel build, we need to ensure that contributors.texi is created
before preface.texi tries to include it.

I know we shouldn't be building the documentation, but because we carry so
many other patches to the build system, we wind up running autoreconf, and...
it happens. Regardless, the patch should be correct even if you don't expect
end users to be building the docs.





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58057>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/