[Octave-bug-tracker] [bug #58055] ftell() incorrect on MS Windows platforms if file is not encoded with CRLF line endings

[Markus Mützel]

Update of bug #58055 (project octave):

              Item Group:        Incorrect Result => Matlab Compatibility   
                  Status:          Ready For Test => Confirmed              

    _______________________________________________________

Follow-up Comment #21:

That fixes the bug for me.
Only downside might be that the performance might be worse now even for the
case when the file actually contains the "correct" line endings. The work
around is only really needed if the file has the "wrong" line endings (and the
user cares about ftell).
But hopefully MS will fix the bug (and the run time test will de-activate the
work around).

Not sure if we care about those kind of things:

diff --git a/liboctave/system/lo-sysdep.cc b/liboctave/system/lo-sysdep.cc
--- a/liboctave/system/lo-sysdep.cc
+++ b/liboctave/system/lo-sysdep.cc
@@ -212,7 +212,7 @@
                          });
 
       if (set_nonbuffered_mode)
-        ::setvbuf (fptr, 0, _IONBF, 0);
+        ::setvbuf (fptr, nullptr, _IONBF, 0);
 
       while (true)
         {


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58055>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/