[Octave-bug-tracker] [bug #58547] gzip()/bzip2() do not handle relative paths in first argument correctly

[Rik]

Follow-up Comment #6, bug #58547 (project octave):

"full pathname" is usually a synonym for absolute pathname.

"foo/bar" is neither relative nor absolute.

"/home/rik/foo/bar" is an example of an absolute pathname
"./foo/bar" is an example of a relative pathname

I think it is just the comment for the code that needs to be adjusted.

The code is


// Return the 'basename' of the pathname in STRING (the stuff after
// the last directory separator).  If STRING is not a full pathname,
// simply return it.

std::string
env::do_base_pathname (const std::string& s) const
{
  if (! (do_absolute_pathname (s) || do_rooted_relative_pathname (s)))
    return s;

  size_t pos = s.find_last_of (sys::file_ops::dir_sep_chars ());

  if (pos == std::string::npos)
    return s;
  else
    return s.substr (pos+1);
}


It looks to me that the first two checks, do_absolute_pathname and
do_rooted_relative_pathname) are meant to check whether the string 's' even
corresponds to a pathname.  Imagine calling


do_base_pathname ("Mickey_Mouse")


This is not an absolute path, and let's assume there is no subdirectory of the
current directory named "Mickey_Mouse".  In that case, both tests return
false--this is not a pathname--and the string is returned unaltered.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58547>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/