octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #53513] Deleting an uicontextmenu object does


From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #53513] Deleting an uicontextmenu object does not update uicontexmenu properties immediately
Date: Wed, 28 Oct 2020 12:24:14 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36 Edg/86.0.622.51

Follow-up Comment #32, bug #53513 (project octave):

I haven't tested yet. But that looks good to me.
I wonder whether it would be cleaner to override the `finalize` method of
`uicontextmenu` instead of having the specific code in the general
`gh_manager::free` function.
That could probably contain basically the code that you add to
`gh_manager::free` followed by `base_graphics_object::finalize (go);`.
Would that also work? From what I can tell, that wouldn't change the order of
execution.

I haven't looked at the second patch yet.

A more general question: Should this go to stable? The graphics code is quite
complicated and there might be side effects we don't see atm. But I trust your
assessment.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?53513>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]