[Octave-bug-tracker] [bug #59813] Build failure with Qt4

[anonymous]

URL:
  <https://savannah.gnu.org/bugs/?59813>

                 Summary: Build failure with Qt4
                 Project: GNU Octave
            Submitted by: None
            Submitted on: Mon 04 Jan 2021 06:12:25 AM UTC
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: None
             Assigned to: None
         Originator Name: Kyle Guinn
        Originator Email: elyk03@gmail.com
             Open/Closed: Open
                 Release: 6.1.0
         Discussion Lock: Any
        Operating System: GNU/Linux

    _______________________________________________________

Details:

Two small errors when trying to build with Qt4.  (Yes I know it's deprecated,
but I'm a Slackware user that's patiently waiting for a new release that ships
with Qt5 as default.)


  CXX      libgui/src/libgui_src_libgui_src_la-octave-dock-widget.lo
libgui/src/octave-dock-widget.cc: In member function ‘void
octave::octave_dock_widget::handle_settings(const octave::gui_settings*)’:
libgui/src/octave-dock-widget.cc:507:47: error: no matching function for call
to ‘QVariant::canConvert(QMetaType::Type)’
     if (dock_geom.canConvert (QMetaType::QRect))
                                               ^


It looks like QMetaType is new in Qt5.  Before that it was QVariant::Rect.


  CXX      libgui/src/libgui_src_libgui_src_la-resource-manager.lo
libgui/src/resource-manager.cc: In member function ‘QString
octave::resource_manager::get_default_font_family()’:
libgui/src/resource-manager.cc:245:26: error: ‘systemFont’ is not a member
of ‘QFontDatabase’
       QFont fixed_font = QFontDatabase::systemFont
(QFontDatabase::FixedFont);
                          ^
libgui/src/resource-manager.cc:245:53: error: ‘FixedFont’ is not a member
of ‘QFontDatabase’
       QFont fixed_font = QFontDatabase::systemFont
(QFontDatabase::FixedFont);
                                                     ^


The systemFont stuff first appeared in Qt 5.2.  In the attached patch I've
copied over the old octave-5.2.0 behavior as a replacement.  I don't know how
correct it is, but it builds and runs for me.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 04 Jan 2021 06:12:25 AM UTC  Name: qt4.patch  Size: 1KiB   By: None

<http://savannah.gnu.org/bugs/download.php?file_id=50639>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59813>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/