octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #59706] Avoid "canonicalize_file_name" on Wind


From: Rik
Subject: [Octave-bug-tracker] [bug #59706] Avoid "canonicalize_file_name" on Windows
Date: Thu, 14 Jan 2021 12:04:06 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.66 Safari/537.36

Follow-up Comment #41, bug #59706 (project octave):

>From comment #40

> * Check if we really need to call `load_path::add` so often (100s of times
if I read the data in the Very Sleepy profile correctly).
> 
> * Check if it is possible to use something else than the canonical path as
the unique identifier when managing the load-path.

I agree with this ordering for priority.  First, reduce the number of function
calls, and if that is still not enough then do the second part and come up
with a different identifier.  As mentioned earlier the device_id + inode_id is
unique and could be an easy substitute.

The coding work for item #1 doesn't need to be done on Windows.  We could put
in a static variable COUNT in load_path::add and see how many times it gets
incremented for a given script (one that changes directories or executes a few
simple actions).  This number becomes the baseline and then we can try
modifications to the code to see whether this number is reduced or not.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59706>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]