[Octave-bug-tracker] [bug #59923] mkoctfile fails on Windows if installed in a path with spaces on a file system without short file names

[Markus Mützel]

Follow-up Comment #12, bug #59923 (project octave):

@John: Thanks for that hint.
I did that, moved Octave to a folder with spaces in its name, and ran the test
suite. It completed with 0 FAILs and no regressions.

So maybe there are not so many places that need to be changed after all.

With that change, I could reproduce the error from comment #0.

A few parameters that are used by mkoctfile as compiler and linker flags have
paths that aren't surrounded by quotes.
Fixing that is surprisingly less straight forwards than I would have hoped.
There are basically two parts to that fix:
Part 1 is to allow using strings containing double quotes in the scripts that
replace the respective parameters in the files in Octave.
Part 2 is adding double quotes around the respective paths in the configure
variables in MXE Octave.

The issue I am seeing is that part 2 contains changes to Makefile.in in MXE
Octave. Doing these changes without part 1 would break compilation of Octave
in MXE Octave.

We maybe could apply part 1 to stable. But that would still leave the release
target broken in MXE Octave.

I also didn't try to completely rebuild from scratch with MXE Octave. So it
might be that other packages won't like these double quotes in their configure
parameters either.

Anyway, with the two attached patches, I am able to use mkoctfile even if
Octave is installed in a path containing spaces (and I remove the conversion
to short file names from the start script).
Part 1: bug59923_mkoctfile_double_quotes.patch
Part 2: bug59923_mxe-octave_double_quotes.patch


(file #50778, file #50779)
    _______________________________________________________

Additional Item Attachment:

File name: bug59923_mkoctfile_double_quotes.patch Size:14 KB
   
<https://file.savannah.gnu.org/file/bug59923_mkoctfile_double_quotes.patch?file_id=50778>

File name: bug59923_mxe-octave_double_quotes.patch Size:1 KB
   
<https://file.savannah.gnu.org/file/bug59923_mxe-octave_double_quotes.patch?file_id=50779>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59923>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/