[Octave-bug-tracker] [bug #60101] symbfact crashes for dense matrices

[Rik]

Follow-up Comment #12, bug #60101 (project octave):

I reviewed the code in some of the other sparse functions, such as ccolamd.cc,
and the solution of declaring two local variables was already in use.  In
fact, there is already a naming convention of sm for SparseMatrix and scm for
SparseComplexMatrix.  With that encouragement, I went ahead and coded the two
local variable solution on the stable branch here:
http://hg.savannah.gnu.org/hgweb/octave/rev/1f9e755bd91e.

A light review of the rest of the places in libinterp where
sparse_array_value() is used shows that etree() is also coded with local block
scope variables.  It doesn't exhibit this problem because it requires a sparse
matrix as input, and the interpreter therefore already has a reference count
above 1 for the variable.  But this isn't good practice and I will check in
another fix for that.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60101>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/