octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #61759] poly misses an error for multidimensio


From: Rik
Subject: [Octave-bug-tracker] [bug #61759] poly misses an error for multidimensional input. Patch attached
Date: Mon, 3 Jan 2022 14:55:26 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36

Update of bug #61759 (project octave):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #2:

@Arun: I reviewed your patch and checked it in under your name here:
http://hg.savannah.gnu.org/hgweb/octave/rev/913f765057d9.  Marking bug as
Fixed and closing report.

I made a few changes for Octave best practices:

1) Use "endif" rather than bare "end".
2) Place error() calls as early as possible.
For example, instead of


if (COND)
  ...
  ...
else
  error ();
endif


write


if (! COND)
  error ();
endif

...
...


3) Eliminated unreachable statement "error ("invalid input")"
4) Re-ordered BIST tests for input validation so they match the order in which
they are encountered in the code.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61759>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]