[Octave-bug-tracker] [bug #61753] Changing assert to panic_impossible

[Rik]

Update of bug #61753 (project octave):

              Item Group:                    None => Other                  

    _______________________________________________________

Follow-up Comment #15:

I reviewed version 2 of the patch.  I made a few changes and am uploading as
bug61753.cset.  I think it is ready for one more review by Arun and then can
be pushed to Mercurial.

There are still some issues with the use of error_if and error_unless. 
Occasionally the code, for example in daspk.cc, is using these functions for
what amounts to input validation.  The problem is that all of these functions
are meant for tests which are present while debugging the code.  When the
NDEBUG macro is set to true these functions, and their checking, are removed
from the code during compilation.  For these instances, which require input
validation, the error_if and error_unless instances should be changed to the
normal pattern of


if (COND)
  error (...)


Lastly, no work has yet been done on the liboctave/ directory.

(file #52813)
    _______________________________________________________

Additional Item Attachment:

File name: bug61753.cset                  Size:33 KB
    <https://file.savannah.gnu.org/file/bug61753.cset?file_id=52813>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61753>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/