[Octave-bug-tracker] [bug #63633] SUNDIALS 6.5.0 requires C++14

[Markus Mützel]

URL:
  <https://savannah.gnu.org/bugs/?63633>

                 Summary: SUNDIALS 6.5.0 requires C++14
                 Project: GNU Octave
               Submitter: mmuetzel
               Submitted: Mon 09 Jan 2023 10:49:24 AM CET
                Category: Configuration and Build System
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 8.0.90
         Discussion Lock: Any
        Operating System: Any
           Fixed Release: None
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Mon 09 Jan 2023 10:49:24 AM CET By: Markus Mützel <mmuetzel>
Building Octave on macOS with Homebrew is currently failing.
E.g.:
https://github.com/gnu-octave/octave/actions/runs/3863542612/jobs/6585794728#step:9:4224

In file included from ../libinterp/dldfcn/__ode15__.cc:49:
In file included from /usr/local/include/nvector/nvector_serial.h:42:
In file included from /usr/local/include/sundials/sundials_nvector.h:50:
In file included from /usr/local/include/sundials/sundials_context.h:44:
/usr/local/include/sundials/sundials_context.hpp:31:32: error: unexpected type
name 'SUNContext': expected expression
    sunctx_ = std::make_unique<SUNContext>();
                               ^
/usr/local/include/sundials/sundials_context.hpp:31:20: error: no member named
'make_unique' in namespace 'std'
    sunctx_ = std::make_unique<SUNContext>();
              ~~~~~^
/usr/local/include/sundials/sundials_context.hpp:31:44: error: expected
expression
    sunctx_ = std::make_unique<SUNContext>();
                                           ^


That is because SUNDIALS 6.5.0 requires `std::make_unique` which was added
with C++14:
https://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique

Octave currently requires a C++11 compatible compiler.

We should probably add a configure check to make sure the detected version of
SUNDIALS is working with the used compiler (and compiler flags).








    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63633>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/