Re: 3.0.1 release? (Reports on mingw build)

[Michael Goffioul]

On Fri, Apr 4, 2008 at 4:23 AM, John W. Eaton <address@hidden> wrote:
> On  3-Apr-2008, Tatsuro MATSUOKA wrote:
>
>  | Hello
>  |
>  | --- "John W. Eaton" <address@hidden> wrote:
>  |
>  | > On  3-Apr-2008, Tatsuro MATSUOKA wrote:
>  | >
>  | > | This time I'll report on mingw build.
>  | > |
>  | > | 1. The  C++ source in liboctave,  lo-sysdep.cc should be patched for 
> win32 native octave
>  | > | (For cygwin it is not required.)
>  | > |
>  | > |
>  | > | *** lo-sysdep.org.cc      Thu Apr  3 03:43:36 2008
>  | > | --- lo-sysdep.cc  Thu Apr  3 08:55:24 2008
>  | > | ***************
>  | > | *** 39,44 ****
>  | > | --- 39,48 ----
>  | > |   #include <fcntl.h>
>  | > |   #endif
>  | > |
>  | > | + #if defined (__WIN32__) && ! defined (__CYGWIN__)
>  | > | + #include <windows.h>
>  | > | + #endif
>  | > | +
>  | > |   #include "file-ops.h"
>  | > |   #include "lo-error.h"
>  | > |   #include "pathlen.h"
>  | >
>  | > What problem does this solve?
>  | >
>  | > jwe
>  | >
>  |
>  | It is required to see the source:
>  | The below uses the Win32 API so that it was impossible to be complied 
> without windows.h included
>
>  OK, I made this change.

I don't understand why this change is needed. At that point, windows.h
should already
have been included using the following sequence:

file-ops.h > str-vec.h > Array.h > lo-utils.h > windows.h (around line 69).

I think that the problem you have is a symptom of another problem:
HAVE_LOADLIBRARY_API
is not defined, that means that the configure check for LoadLibrary failed.

The patch above is not a problem for MSVC. But when something does not work
under MinGW, the first thing you should ask yourself is "Damn, why does it work
under MSVC?". Because if it wouldn't work, then I would also have the problem,
and I would probably fix it ASAP... :-)

Michael.