octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Rotation fixes


From: John W. Eaton
Subject: Re: Rotation fixes
Date: Fri, 27 Aug 2010 16:18:09 -0400

On 27-Aug-2010, Jordi Gutiérrez Hermoso wrote:

| 2010/8/26 John W. Eaton <address@hidden>:
| > The point is that we don't need all the changsets that include the
| > debugging code then the removing of the debugging code.  Just send us
| > one changeset that has the end result including the ChangeLog
| > entries.  We don't need to see every intermediate step you took along
| > the way.
| 
| Okay, I folded the changesets into one and added Changelog entries in
| imitation of the surrounding entries I saw. You may now pull:
| 
|     http://bitbucket.org/jordigh/gnu-octave
| 
| If you apply the attached patch instead, it would be nice if you
| verified that there are no encoding errors with my name. Pulling would
| ensure that wouldn't happen, because hg is byte agnostic and will thus
| preserve the UTF-8 encoding, which might not happen if the patch is
| applied (sorry to be so wary, but I've had this happen a couple of
| times already).

I checked in this change after making mostly cosmetic changes.

The one significant change I made was to have the new internal
calc_dimensions function return an int instead of an octave_value
object.

jwe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]