|
From: | John W. Eaton |
Subject: | Re: UGLY_DEFS, configure.ac, & toplev.cc on MacOS X |
Date: | Sat, 02 Mar 2013 08:23:24 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 |
On 03/01/2013 07:54 PM, Ben Abbott wrote:
Adding a single backslash allows me to build. Ben $ hg diff diff --git a/configure.ac b/configure.ac --- a/configure.ac +++ b/configure.ac @@ -2853,7 +2853,7 @@ ## We have to insert extra levels of backslash quoting here so that ## the right thing ends up in oct-conf.h. -UGLY_DEFS=`echo $DEFS | $SED 's,\\",\\\\\\\\\\\\\\\\\\",g'` +UGLY_DEFS=`echo $DEFS | $SED 's,\\",\\\\\\\\\\\\\\\\\\\",g'` AC_MSG_NOTICE([defining UGLY_DEFS to be $UGLY_DEFS]) AC_SUBST(UGLY_DEFS)Rik, The attached change allows me to build. If it doesn't break your build should this be pushed?
I checked in two changes to eliminate UGLY_DEFS instead: http://hg.savannah.gnu.org/hgweb/octave/rev/2a4f83826024 http://hg.savannah.gnu.org/hgweb/octave/rev/cf6788da4152While making this change, I noticed that UGLY_DEFS appeared three times in the sed commands. Once in a substitution for OCTAVE_CONF_DEFS and twice for OCTAVE_CONF_UGLY_DEFS. Without the extra substitutions, a single sed command might not be too long but I left it split in two parts anyway.
jwe
[Prev in Thread] | Current Thread | [Next in Thread] |