[Octave-patch-tracker] [patch #10147] interpreter: Avoid string construction

[Markus Mützel]

Follow-up Comment #1, patch #10147 (project octave):

This patch is quite large which makes it difficult to review.

Could you please split it up in smaller changes. E.g., one that only changes
some `map` objects to `unordered_map`s, another one that replaces string
literals with `static const string`s, yet another one that makes `m_fullname`
a new class member, ...
That would probably make it much easier to digest.

Additionally, we try to avoid tabulators for white space in code. They display
differently for different editors or settings. I've seen pretty much
everything from 2 characters to 16 characters per tab... (Is it 8 for your
editor?)

I didn't try that patch yet.
Does it compile for you? It looks like the fcn_info_rep constructor is missing
an argument. Or I can't see where `m_file_name` gets actually set...

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10147>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/