[Octave-patch-tracker] [patch #10147] interpreter: Avoid string construction

[Petter Tomner]

Follow-up Comment #2, patch #10147 (project octave):

OK I'll split the patch up and post them here. I'll rebase to HEAD too.

I missed the tab rule. I'll untabify. 

>  Does it compile for you? It looks like the fcn_info_rep constructor is
missing an argument. Or I can't see where `m_file_name` gets actually set...
Yes it compiled, even though I am new to hg so I might have messed something
up.

'm_full_name' is set in the constructor initializer list. It is impossible to
see from the patch diff that 'name' is split up into 'package_name' and back
into 'name' in the ctor. So 'name' is initially the full name. (I should have
used 'nm' instead for setting m_full_name for clarity.)


      fcn_info_rep (const std::string& nm)
        : name (nm), package_name (), m_full_name (name), local_functions (),
          /* ... */
      {
        std::size_t pos = name.rfind ('.');
        if (pos != std::string::npos)
          {
            package_name = name.substr (0, pos);
            name = name.substr (pos+1);
          }
      }


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10147>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/