[Octave-patch-tracker] [patch #10288] Implementation of Matlab function tensorprod

[Kasper H. Filtenborg]

Follow-up Comment #18, patch #10288 (project octave):

Thank you for pointing out the changes that you made. They make a lot of
sense, and they will be good to have as a reference should I have another
contribution.

I have looked through the file and have not spotted any problems. I have only
two really minor things:
 - Double space in line 53 (after the colon)
 - Shouldn't the use of single and double quotes be flipped in the error
messages where both are used so that e.g. '"all"' is used instead of "'all'"
to produce "all" in the printed error message? I think this is more consistent
with other printed information as e.g. "help tensorprod". (I see that some
functions are using 'foo' and others "foo" in error messages.)

And just for my understanding, how does the compiler know not to include the
changes from the patch? Shouldn't there be another branch for version 9?


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10288>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/