[Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional.

[Markus Mützel]

Follow-up Comment #2, patch #10278 (project octave):

I haven't tested the patch. Just some initial remarks:
* I can't see where SUNDIALS_EXPORT is defined. What is it supposed to do?
* CamelCase in function names is discouraged in Octave's sources. Use all
lower case with underscores as separators (unless there is a good reason to
deviate from that convention here).
* Many functions have names that contain "OCT" or "_Octave". Would it make
sense to move them to the `octave` namespace instead?
* Remove the include guard `__CONFIG_H_INCLUDE_GUARD` from `__ode15__.cc`.
`.cc` files aren't supposed to be included in other files normally. Is this
different for this file?
* Revert the white space changes in your patch for the pre-processor macros.
The hash `#` is supposed to be in column 1. Spaces for indentation follow
after the `#`. Use two spaces for indentation.
* Avoid using old-style cast in NV_CONTENT_C. Use `reinterpret_cast` instead.
Or does that not work for some reason here?
* Use a space between function name and following opening parenthesis.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10278>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/