[Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional.

[Markus Mützel]

Follow-up Comment #8, patch #10278 (project octave):

Afaict, SUNDIALS_EXPORT is defined like this in the headers:

#ifdef SUNDIALS_STATIC_DEFINE
#  define SUNDIALS_EXPORT
#  define SUNDIALS_NO_EXPORT
#else
#  ifndef SUNDIALS_EXPORT
#    ifdef sundials_generic_EXPORTS
        /* We are building this library */
#      define SUNDIALS_EXPORT __declspec(dllexport)
#    else
        /* We are using this library */
#      define SUNDIALS_EXPORT __declspec(dllimport)
#    endif
#  endif

#  ifndef SUNDIALS_NO_EXPORT
#    define SUNDIALS_NO_EXPORT 
#  endif
#endif


That is used to correctly dllimport functions from the SUNDIALS library (on
Windows). Using it like this for functions exported from a library in Octave
is wrong.
Remove it everywhere you used it.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10278>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/