|
From: | Sarrah Bastawala |
Subject: | [Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional. |
Date: | Thu, 2 Mar 2023 11:25:16 -0500 (EST) |
Follow-up Comment #15, patch #10278 (project octave): [comment #11 comment #11:] > The current naming convention is a bit confusing. With some functions starting with `OCT` or `_OCT` and some ending with `_Octave`. > If those function have 1-to-1 correspondents in SUNDIALS, you could use that name with their conventions imho. But, I'd vote for moving them to the `namespace octave`. Use the macros `OCTAVE_BEGIN_NAMESPACE(octave)` and `OCTAVE_END_NAMESPACE(octave)` for that. The current conventions were just based on how existing implementations in SUNDIALS using other libraries differentiated their wrappers from the default implemented functions, such as this implementation of a vector using OpenMP https://sundials.readthedocs.io/en/v6.2.0/nvectors/NVector_links.html#the-nvector-openmp-module . And for generic type names in SUNDIALS, Carlo and I had just decided to replace the `SUN` with `OCT`. Hence the confusion ... If we were also to change the Naming Style from CamelCase,I believe they could be moved to `namespace octave` as our names wouldnt clash with the defualt implementations of those functions in Sundials as well. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/patch/?10278> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |