[Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional.

[Sarrah Bastawala]

Follow-up Comment #22, patch #10278 (project octave):

[comment #21 comment #21:]
> [comment #20 comment #20:]
>  
> I am currently facing a slight issue in the operating system I work in, but
I'll make all these changes at once and commit soon. 

Hello @mmuetzel and @cdf, thank you for waiting. I have made all the suggested
style changes and rebased the current code on the current head of the default
branch, and fixed the slight errors caused due to the same (I suppose the
macro for declaring the Octave namespace has changed). 

The now working and able to merge with gnu-octave/octave:default branch is now
located at https://github.com/sarrah-basta/octave/tree/gsoc-submission-final .


I could squash the recent commits into 1 final if necessary to make it easier
to review. 



[comment #18 comment #18:]
> All other .oct libraries in Octave are defined in one single .cc file (+
headers). Would it make sense to merge your changes into `__ode15__.cc`?
> Additionally, the .oct file libraries are not meant to be linked to by other
projects. They are rather `dlopen`ed by Octave on runtime. Do we really need a
header with the declarations in that case?
> 

@mmuetzel, this is the only suggested change I have not yet implemented. I
suppose the current structure once again mimics so -called "implementations"
in the SUNDIALS API and I had hence placed them in seperate files to be
pre-compiled. From Octave's perspective though, I believe the functions in the
header files are just helper functions to the `__ode15__` function, and hence
could be placed in the `__ode15__.cc` file itself, as the SUNDIALS API is
calling them via pointers instead of function declarations. I will still test
this once on a seperate branch and link the commit here once it works  


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10278>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/