[Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional.

[Sarrah Bastawala]

Follow-up Comment #27, patch #10278 (project octave):

Hello @mmuetzel, thank you for all your comments. 

As the rebase caused quite some changes, as changes to the coding style were
made to the `__ode15__.cc` file which conflicted with my own changes, it took
me some time and a lot of commits to figure that out. Since the current
changes were spread over multiple commits, and seeing your comments you too
had some difficulty understanding how they were structured, I have fixed all
the whitespace and unwanted changes and *squashed* all my commits into one
with a clean code diff for you to review, situated at 
https://github.com/sarrah-basta/octave/tree/new-gsoc-final-aptch . 

This contains all changes except the following:

[comment #26 comment #26:]
> These changes to `config-module.awk` will hopefully take care of the new
file :

I tried testing this, and while it kind of works, meaning the code for the
implementation I have written, containing Octave Wrappers for IDA, works
correctly, i.e the oct-sundials.* files are being compiled and used correctly,
it runs into an error related to SUNContext (defined as a configure flag) in
the KLU part (which was supprted prior to my project). I will try figuring out
the exact problem and fix the script so that the files are not hardcoded soon.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10278>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/