Re: Level Comment Tool - further development

[David Philippi]

Am Mi, den 14.04.2004 schrieb Neil Mitchell um 21:22:
> > onClick="window.document.form.comment.value =

> It's javascript 1.0, but the thing that might stop it working for some
> things is the DOM support (which is pretty patchy on all browsers). The

No, IE is doing nonsense and Konqueror is trying to imitate it.

> dubious feature is probably this.title, ('this' is not guaranteed to be
> anything for the caller in some versions, and title may not return anything
> on old browsers) and replacing that with 'name' directly can probably be
> done at the PHP level without too much hassle.

Even worse, the code quoted above is illegal for sure. There is no
document.form, it's document.forms[0] (if it is the first) or you have
to give it a name and call it by document.that_name. I know the bug
above because I reported it as the reason for an evangelism bug myself.

> The other thing that may cause issues is that sometimes onClick doesn't work
> for non-active elements, and doesn't give visual feedback (i.e. no hand
> cursor), so usually its better to do <a href="javascript:codehere"><img...
> /></a>, without much additional hassle and more standard nature.

onclick should usually work (don't write onClick, it's illegal in xhtml)
with any halfway recent browser.

> Then of course, you could just slap a use a recent browser notice on it, and
> use more modern stuff.

I'd say it should work with all usual linux browsers, personally I don't
care about wheter it supports IE but it's probably better if it does.

Bye David