poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH builder.git] master.cfg: add GNU poke builder


From: Mohammad-Reza Nabipoor
Subject: Re: [PATCH builder.git] master.cfg: add GNU poke builder
Date: Tue, 29 Nov 2022 12:55:58 +0100

Hi Frank.

On Mon, Nov 28, 2022 at 04:53:14PM -0500, Frank Ch. Eigler wrote:
> Another suggestion: change your dejagnu .exp files so that the
> test name strings passed to "pass" "fail" etc. are persistent
> and generic, and not contain irrelevant stuff like a local
> complete path name.
> 
> That's because having these paths in the test names makes those test
> cases different from run to run, and thus the results are not directly
> comparable.  For example:
> 
> https://builder.sourceware.org/testrun-diffs?mode=differences&commitish=4a4313189ff5c3e354c977f8eca6621329af3279&commitish=c6cb32e4a10b994e26e32266eaf7cce47f7128d5
> 
> It'd be better just to print the `basename $path` or something like that
> instead.
> 

I just fixed it in commit 68208454a874d6c03f79dbe191ed1f7b4de633fc.
Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]