poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH builder.git] master.cfg: add GNU poke builder


From: Jose E. Marchesi
Subject: Re: [PATCH builder.git] master.cfg: add GNU poke builder
Date: Wed, 23 Nov 2022 12:53:55 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> BTW. I tried on debian-i386, but got some test failures/crashes:
>
> The following patch seems to fix that:
>
> diff --git a/libpoke/pkl-lex.l b/libpoke/pkl-lex.l
> index 4c9b013e..ef562ccb 100644
> --- a/libpoke/pkl-lex.l
> +++ b/libpoke/pkl-lex.l
> @@ -176,7 +176,7 @@ build_overflow_error_msg (uint64_t value, int width)
>                          : "");
>  
>    asprintf (&msg,
> -            "signed overflow\ntry: %luU%s as int<%d>",
> +            "signed overflow\ntry: %" PRIu64 "U%s as int<%d>",
>              value, suffix, width);
>    return msg;
>  }

I just applied that fix in master.

We only develop in 64-bit, so we usually only catch these regressions
before doing releases, when I make a point to test in 32-bit.

The autobuild already paid back, in a way ;)
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]