[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5520] Case filter for missing values.

From: John Darrington
Subject: [patch #5520] Case filter for missing values.
Date: Sat, 04 Nov 2006 05:52:58 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20060607 Debian/1.7.12-1.2

Follow-up Comment #3, patch #5520 (project pspp):

 I see here looks good. But I don't see the code for the
  casefilter functions. Are they in new files that were left out of the

Sorry.  New patch attached.

  The GNU coding standards say to format do-while loops as:
    a = foo (a);
  while (a > 0);


  I'd prefer to have a casefilter_clone function rather than open-coding
  it in casereader_clone and casefile_get_reader.

  I'm not actually sure we need to ref-count casefilters: it     seems that
  there's an explicit casefilter_create and casefilter_destroy at   the
  top level anyhow. Do casefilters ever outlive that top-level

I wondered about this too.  I think currently the answer is "no".    Maybe
the best thing is to do away with the ref counting, until we know that its


Additional Item Attachment:

File name: casefilter2.patch              Size:42 KB



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]