[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5520] Case filter for missing values.

From: Ben Pfaff
Subject: [patch #5520] Case filter for missing values.
Date: Sat, 04 Nov 2006 23:41:43 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20060830 Firefox/ (Debian-1.5.dfsg+

Follow-up Comment #4, patch #5520 (project pspp):

> Maybe the best thing is to do away with the ref counting, until we know
> its necessary.

That would be my inclination.

Looking at casefilter.[ch]:

- You could use xnmalloc, xnrealloc in casefilter_create,
casefilter_add_variables, although it'd be difficult for those particular
calls to be unsafe.

- Some functions lack a comment.

Otherwise looks OK to me.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]