[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #5520] Case filter for missing values.
|
From: |
Ben Pfaff |
|
Subject: |
[patch #5520] Case filter for missing values. |
|
Date: |
Sat, 04 Nov 2006 23:41:43 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060830 Firefox/1.5.0.7 (Debian-1.5.dfsg+1.5.0.7-1) |
Follow-up Comment #4, patch #5520 (project pspp):
> Maybe the best thing is to do away with the ref counting, until we know
that
> its necessary.
That would be my inclination.
Looking at casefilter.[ch]:
- You could use xnmalloc, xnrealloc in casefilter_create,
casefilter_add_variables, although it'd be difficult for those particular
calls to be unsafe.
- Some functions lack a comment.
Otherwise looks OK to me.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5520>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/