[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5567] formatted data input update and regression suite

From: John Darrington
Subject: [patch #5567] formatted data input update and regression suite
Date: Tue, 21 Nov 2006 10:53:31 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Debian/1.7.8-1

Update of patch #5567 (project pspp):

             Assigned to:                     jmd => blp                    


Follow-up Comment #1:

Only a few points:

0 There are a number of places where you have +char tmp[6];+ and later you
are indexing into tmp with some integer expression.  I wonder if it would be
safer to use +struct string+ in these places instead?

0 There are a number of instances of isxdigit, and other instances of
isdigit/isspace/isalpha.  Are you sure that locale/non-locale dependent
versions are being used where appropriate?

0 I still think that it may be a good idea (at least eventually) to  allow
locale dependent versions of data input.  For example, users in a German
locale might well have a large text file of the form:
Di Okt 21 18:49:56 CST 2006
Mi Okt 22 17:59:36 CST 2006
which they'd want to parse into dates in PSPP.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]