[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5731] Reduce platform dependence

From: John Darrington
Subject: [patch #5731] Reduce platform dependence
Date: Fri, 09 Feb 2007 00:54:35 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20061113 Debian/1.7.8-1sarge8

Follow-up Comment #2, patch #5731 (project pspp):

This is an improvement, but obviously there is more to be done.

  Remove `stat-macros' module.

Why did you do that?  It no longer builds, since several files include

While we're adjusting gl macros, can we get rid of strstr  which no longer
exists in gnulib ?

 +/* Spawn an interactive shell process. */
 +static bool
  shell (void)
   int pid;
I think it's easier to read, if you put the function inside the #if /

 -  if (fn_is_absolute (name))
 +  if (name[0] == '/')
     return xstrdup (name);

I prefer this how it was before.  Especially, given the purpose of this
patch, and that w32 doesn't use '/' to seperate directories.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]