[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5731] Reduce platform dependence

From: Ben Pfaff
Subject: [patch #5731] Reduce platform dependence
Date: Fri, 09 Feb 2007 04:44:39 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Follow-up Comment #3, patch #5731 (project pspp):

>This is an improvement, but obviously there is more to be done.

Portability is a process, not a product...

>> Remove `stat-macros' module. 
>Why did you do that? It no longer builds, since several files 
>include stat-macros.h

stat-macros.h is not useful.  Its functionality has been subsumed by the
sys_stat module.

I've now dropped #include "stat-macros.h" from everywhere it was included.

>While we're adjusting gl macros, can we get rid of strstr which no
>longer exists in gnulib ? 


> I think it's easier to read, if you put the function inside the
> #if / #endifs 

OK, done.

>I prefer this how it was before. 

OK, done.  I changed this to:

/* Returns true iff NAME specifies an absolute file name. */
fn_is_absolute (const char *name)
  return name[0] == '/';

We could check for \ under windows, but what's the proper test macro for
that?  Should it be __WIN32__?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]